- 
                Notifications
    You must be signed in to change notification settings 
- Fork 768
Refactor pagination #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            bitwiseman
  wants to merge
  17
  commits into
  hub4j:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
bitwiseman:pagination-cleanup2
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Refactor pagination #2099
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    f2991da    to
    7fdfb85      
    Compare
  
    da424c8    to
    01f8dfa      
    Compare
  
    | Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@             Coverage Diff              @@
##               main    #2099      +/-   ##
============================================
+ Coverage     85.02%   85.34%   +0.31%     
- Complexity     2496     2527      +31     
============================================
  Files           237      235       -2     
  Lines          7353     7280      -73     
  Branches        388      373      -15     
============================================
- Hits           6252     6213      -39     
+ Misses          871      851      -20     
+ Partials        230      216      -14     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
1fc163c    to
    7857e89      
    Compare
  
    6fdda65    to
    7a592ed      
    Compare
  
    7a592ed    to
    4948299      
    Compare
  
    247c5b4    to
    7917b59      
    Compare
  
    7917b59    to
    d722709      
    Compare
  
    1b4f37d    to
    8b81765      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: